This repository has been archived by the owner on Jan 23, 2021. It is now read-only.
Remove call to registration.update() from demo #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM (I do wish we could keep the longer version for readability, but +1 to shortening for character length) |
jeffposnick
added a commit
that referenced
this pull request
Dec 11, 2015
Remove call to registration.update() from demo
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @gauntface @wibblymat @addyosmani
There's no need to call
registration.update(), and I think its presence has caused some confusion (see mozilla/oghliner#224).This also shortens the name of the
registrationparameter down toregto make it easier to adhere to the new 80 character line length.