This repository has been archived by the owner on Jan 23, 2021. It is now read-only.
Remove the sourcemap comment when inlining sw-toolbox #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lgtm |
jeffposnick
added a commit
that referenced
this pull request
Mar 16, 2016
Remove the sourcemap comment when inlining sw-toolbox
|
this does not work with version 3.2.0, after generating the servier-worker.js by command-line, I still have the entry: |
|
That's due to GoogleChromeLabs/sw-toolbox#149 and should hopefully be resolved in an upcoming |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @addyosmani @wibblymat @gauntface
We can't rely on users including the
sw-toolboxsourcemap file at a specific location in their web server when usingsw-precacheto inline thesw-toolboxcode. This PR removes the reference to the sourcemap file to stop errors from being logged in the JS console.A more robust solution is tracked in #95.
Closes #93