Skip to content
This repository has been archived by the owner on Aug 31, 2021. It is now read-only.

Publish Sanely #224

Merged
merged 5 commits into from Feb 16, 2017
Merged

Publish Sanely #224

merged 5 commits into from Feb 16, 2017

Conversation

gauntface
Copy link

@gauntface gauntface commented Feb 16, 2017

@jeffposnick apologies for the mess with previous release.

This PR does a few things:

  1. Simplifies the release process to just rely on npm's package.json > files to select files to publish.
  2. To keep top level sw-toolbox file, changed the build location - not totally happy with this but best solution and I've added files to gitignore (They used to be in master and that's where my dis-taste formed).
  3. npm-publish-scripts can be used from the command line and has a reasonable usage flow. Its no longer needed in package.json scripts. I'd still like publishers to use it (It does basic sanity checks like running npm run build, npm run test and creating git tags etc).
  4. Publishing docs can now just be done with npm-publish-scripts publish-docs. sw-toolbox has no jsdocs so it's just pushing to github pages.

If you want to confirm that the output to npm is sane, run npm pack.

Fixes #223

@jeffposnick
Copy link
Contributor

If the idea is that npm-publish-scripts is still the recommended way of publishing things, then I'd feel much better if we continued listing it alongside the compatible version info package.json, and then ensured that we ran the local copy by referencing it inside of package.json's scripts field.

Relying on folks to use a globally installed version of npm-publish-scripts without having any means of enforcing versioning seems like it's asking for trouble, and we're run into similar trouble if you released any breaking changes in npm-publish-scripts moving forward.

@gauntface
Copy link
Author

Done.

package.json Outdated
},
"main": "lib/sw-toolbox.js",
"repository": "https://github.com/GoogleChrome/sw-toolbox",
"dependencies": {
"serviceworker-cache-polyfill": "^4.0.0",
"path-to-regexp": "^1.0.1"
"npm-publish-scripts": "^4.1.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in devDependencies, I believe.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm such a noob.

@jeffposnick jeffposnick merged commit 7fbf15e into master Feb 16, 2017
@jeffposnick
Copy link
Contributor

Thanks for taking care of this!

@jeffposnick jeffposnick deleted the release-update branch February 16, 2017 20:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate publishing issue with 3.5.0 release
2 participants