Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari integration test flakiness #2755

Closed
jeffposnick opened this issue Feb 14, 2021 · 0 comments · Fixed by #2928
Closed

Safari integration test flakiness #2755

jeffposnick opened this issue Feb 14, 2021 · 0 comments · Fixed by #2928
Labels
Browser Compatibility Tied to service worker behavior in a specific browser. Testing Related to tests and test runners. workbox-broadcast-update workbox-window

Comments

@jeffposnick
Copy link
Contributor

There is some longstanding flakiness in our integration tests with Safari. With Safari 14.0.2, I can see the failures locally and on GitHub Actions with the should broadcast a message to all open window clients from workbox-broadcast-update, and reports all events for an external SW registration from workbox-window.

The commonality between those two tests is that they involve opening new tabs using webdriver, and relying on the service worker from the second tab to influence the behavior of the first.

From doing some local, manual testing, I don't believe that this is an issue outside of webdriver.

It would be great to get to the bottom of what's going on, as both tests pass in Firefox and Chrome.

C.f. #2321 which tracked a failure with the workbox-window test that also affected Firefox, but which I think is resolved. This failure seems to be something else.

@jeffposnick jeffposnick added workbox-broadcast-update Browser Compatibility Tied to service worker behavior in a specific browser. Testing Related to tests and test runners. workbox-window labels Feb 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Browser Compatibility Tied to service worker behavior in a specific browser. Testing Related to tests and test runners. workbox-broadcast-update workbox-window
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant