Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for Align Tool are failing on Mac #408

Closed
lavyda opened this issue Nov 8, 2019 · 9 comments
Closed

Test for Align Tool are failing on Mac #408

lavyda opened this issue Nov 8, 2019 · 9 comments

Comments

@lavyda
Copy link
Contributor

lavyda commented Nov 8, 2019

Running tests for Align Tool on Mac causes these tests to fail:

  • Can adjust column order
  • Can adjust row order
  • Can adjust row order

How to reproduce:
Run tests for Align Tool

Expected behaviour:
All tests should pass.

Fix:
Use helper method to determine ctrl/cmd key.

@adhrinae
Copy link
Contributor

adhrinae commented Nov 11, 2019

I'm working on the other issue and the tests are failing because of this issue.
but I found this cannot be resolved easily.
It seems like Meta + any key doesn't work well in macOS.

puppeteer/puppeteer#1313

@lavyda
Copy link
Contributor Author

lavyda commented Nov 12, 2019

It's weird because when I run tests (#409) on my Mac they pass.

@argyleink
Copy link
Member

are these still failing after #409 merged?

@lavyda
Copy link
Contributor Author

lavyda commented Dec 6, 2019

I think #409 hasn't been merged yet

@argyleink
Copy link
Member

now it's merged!

@lavyda
Copy link
Contributor Author

lavyda commented Dec 6, 2019

great! for me all tests pass

@argyleink
Copy link
Member

cool! feel comfy closing this issue?

@adhrinae
Copy link
Contributor

adhrinae commented Dec 7, 2019

Yes. You can close this issue. 👍 Sorry for taking time to check this out.

@argyleink
Copy link
Member

no prob! happy there's folks helpin 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants