Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color picking needs improvements #424

Closed
Costas-Zeimpekis opened this issue Dec 19, 2019 · 2 comments
Closed

Color picking needs improvements #424

Costas-Zeimpekis opened this issue Dec 19, 2019 · 2 comments
Labels
🐜 bug Something isn't working 🗣 conversation we're just chattin ¿ question ? Further information is requested

Comments

@Costas-Zeimpekis
Copy link

OS windows 10
When I choose an element the color that is already set does not appear on the color panel
When I change color that should change the element in real time, so I do not need to set the color see if it is the one I like and if not go trough the process again

@argyleink
Copy link
Collaborator

I agree, the behavior you describe is the intended behavior of the tool. Can you share more details about when and where this is happening to you? I did some testing on my windows machine, and here's my report:


  1. when selecting something on the page, the color picker should update and show the text color, background color and border color (unless it's an svg, which it then shows fill, stroke, etc)

I wasn't able to reproduce this issue on windows. the elements I clicked on properly updated the color panel swatches with the respective color. Are there specific types of things you're selecting? VisBug does show a transparent color if nothing is set for that element.


  1. when an item is selected and I'm selecting a new color via the picker, the element should update without needing to confirm the color

unfortunately this is a problem with the color picker input element on windows chromium. this problem does not exists on mac builds of chromium. there is active work happening on the color input, so there's a decent potential this issue get's resolved with that element update. essentially the bug is that the input element isn't emitting a change event, so visbug isn't being told there's a new color until the user presses the confirmation button in the popup. 😢 visbug prefers to lean on the system elements so the experience feels native. i'm not sure how other apps get around this ux issue 🤷‍♂

color picker on edge (proof of active work happening):
color-picker-edge

color picker on chrome:
color-picker-chrome

@argyleink argyleink added ¿ question ? Further information is requested 🐜 bug Something isn't working 🗣 conversation we're just chattin labels Dec 27, 2019
@argyleink
Copy link
Collaborator

curious if this is still happening?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐜 bug Something isn't working 🗣 conversation we're just chattin ¿ question ? Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants