Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permission dialog should be automatically closed and resolved when the managed policy gets updated #41

Closed
emaxx-google opened this issue Sep 2, 2016 · 1 comment · Fixed by #1134
Labels

Comments

@emaxx-google
Copy link
Collaborator

emaxx-google commented Sep 2, 2016

Currently, when the managed policy gets updated, it has no influence on the previous requests that are blocked waiting for user decision (i.e. until it presses "Allow" or "Block").

Instead, if the updated managed policy contains values that correspond to the previously attempted permission requests, they should become immediately resolved by the Connector app.

P.S. This issue produces problems mostly when running on the login screen: it may be that the applications will be installed and started before the actual value for the managed policy is received.

@emaxx-google
Copy link
Collaborator Author

Some pointers:

  • Documentation regarding the dialog and the "force_allowed_client_app_ids" policy: docs/connector-app-api.md#permissions-for-the-pcsc-api-consumers
  • Code that decides whether to show the dialog or use the policy is at //third_party/pcsc-lite/naclport/server_clients_management/src/permissions_checking/checker.js (specifically, see the check() method).
  • The actual code that shows the dialog is at user-prompting-checker.js in the same directory.
  • The actual code that reads the policy value (via the chrome.storage.local.get() API) is at managed-registry.js in the same directory. That code already supports listening for the update notifications (see the chrome.storage.onChanged.addListener() call); so the bug is only about this update notification not being delivered to the code that shows the dialog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant