Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript compilation fails for mixed node/web project due to conflict with @types/node "url" module #33

Open
forshtat opened this issue Oct 19, 2020 · 0 comments

Comments

@forshtat
Copy link

forshtat commented Oct 19, 2020

Expected Behavior

I expected 'native-url' to be a drop-in replacement for the URL class available in Node for files that are used in the web browser only.

Actual Behavior

TypeScript compilation fails with

node_modules/@types/node/url.d.ts:76:11 - error TS2300: Duplicate identifier 'URL'.

76     class URL {
             ~~~

  node_modules/native-url/third_party/url.d.ts:100:9
    100   class URL {
                ~~~
    'URL' was also declared here.

Steps to Reproduce the Problem

  1. Create a TypeScript project with both '@types/node' and 'native-url' installed
  2. Try to compile it

So far I could only workaround by mapping the declarations for 'native-url' to some bogus file by adding to the tsconfig.json the following lines:

    "baseUrl": ".",
    "paths": {
      "native-url": ["types/native-url"]
    }

I wonder if there is a better solution, or if I am doing it all wrong, or if this should be addressed by the maintainers of the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant