Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeprecationWarning: setDaemon() is deprecated, set the daemon attribute instead #35

Open
whimboo opened this issue Jan 18, 2024 · 1 comment

Comments

@whimboo
Copy link
Contributor

whimboo commented Jan 18, 2024

When I run the unit tests I can see the following deprecation warning:

pywebsocket3/msgutil.py:130: DeprecationWarning: setDaemon() is deprecated, set the daemon attribute instead
  self.setDaemon(True)
@ricea
Copy link
Collaborator

ricea commented Jan 18, 2024

Okay, so the daemon attribute was added in 2.6 and 3.3.

For Python 2 we only support 2.7 or newer, so that is fine.

The oldest Python 3 version we tested for when Travis was working was 3.5. I don't think we've officially dropped support for older versions, but I think it would be safe to add a requirement for a minimum Python 3 version of 3.3, or maybe even 3.5 since I've no idea whether 3.3 would really work or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants