Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An additional div markup is wrapped around each router component by withQuicklink HOC #193

Open
anton-karlovskiy opened this issue Jul 2, 2020 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@anton-karlovskiy
Copy link
Contributor

anton-karlovskiy commented Jul 2, 2020

Describe the bug
As you can see in the HOC, we have an additional div markup wrapping around the Component (probably it would be a route component) so inserting that div markup could break the app styling since the app styling does not expect another div to be inserted by withQuicklink HOC.
Capture

To Reproduce
If we use nest CSS selector without considering that div, we might break the styling.

Expected behavior
I hope we could avoid adding any wrapping markup around a route component if possible. At least, I hope we manage to avoid impacting the rest of the app as well as the styling in any case.

Version:

  • Quicklink 2.0

cc @addyosmani @demianrenzulli

@alexandergottlieb
Copy link

This breaks flex styling.

If the div is necessary, can we add some ability to style it, or set it to display: contents?

@XhmikosR XhmikosR added the help wanted Extra attention is needed label Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants