Skip to content
This repository has been archived by the owner on Jan 23, 2021. It is now read-only.

sw-precache 4.2.0, build broken on bower #200

Closed
chenav opened this issue Oct 19, 2016 · 7 comments
Closed

sw-precache 4.2.0, build broken on bower #200

chenav opened this issue Oct 19, 2016 · 7 comments

Comments

@chenav
Copy link

chenav commented Oct 19, 2016

capture d ecran 2016-10-19 a 16 15 56

Impossible of running grunt script calling sw-precache.
Fallback to 4.1.0 here seems to be working.

C.

@jeffposnick
Copy link
Contributor

Hello @chenav—what version of NodeJS are you using? (Output of node -v.)

That code is in one of the dependencies, pretty-bytes, which did get its version updated in the latest sw-precache release. I'll take a look into how it's being used, and can roll back to a previous version of pretty-bytes if it comes to that.

@chenav
Copy link
Author

chenav commented Oct 19, 2016

Hey @jeffposnick ,

The quality server on which I test my deployment gruntfile, runs node v0.12.13.

I may have to upgrade it then.

C.

@jeffposnick
Copy link
Contributor

Thanks for passing along the node version. Upgrading your server is probably a good idea, regardless, since v0.12 is currently in maintenance mode and is scheduled to stop being supported at the end of the year.

That being said, the intention was not to force folks to update, so I'll push out something that will still maintain v0.12 compatibility via changes to how we're using pretty-bytes.

@jeffposnick
Copy link
Contributor

(It's frustrating that Travis CI wasn't responding yesterday, because we do still test on node v0.12 there, and it would have presumably caught this. Oh well!)

@chenav
Copy link
Author

chenav commented Oct 19, 2016

Roger that.
The community is there to find stuff like that, rapidly :)

Anyway, thanks for your good work !

@jeffposnick
Copy link
Contributor

I've pushed 4.2.1 to npm, so feel free to give it another try.

@chenav
Copy link
Author

chenav commented Oct 20, 2016

Works perfectly on node 0.12.13 now.

Thx.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants