Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention babel-react-optimize #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kurtextrem
Copy link
Contributor

closes #9

@iamakulov
Copy link
Collaborator

Thanks, great addition!

1. One thought about babel-react-optimize: should we avoid mentioning it? The primary use-case of this repo (as I see it) is:

  • a reader with a non-optimized app comes here,
  • they read over the libraries
  • and they apply plugins/tips from suitable sections to optimize the app.

babel-react-optimize doesn’t fit this use-case (the tip doesn’t help to make the app smaller); moreover, in fact, it advertises this solution (some readers might neglect the warning or skip it and install this preset)

2. Also: should we give an example of the transformation that the transform-react-pure-class-to-function plugin does? E.g., like we do for date-fns.

@kurtextrem
Copy link
Contributor Author

  1. Hm, I see your point. However, I think people come here to learn about "how can I make my app faster/reduce bundle size?". So to say they are here to learn.
    This is why I would teach them "not everything is good".

But I guess this one would be even better: Get a PR merged to babel-react-optimize to warn there, instead of on a 3rd party repo :)

  1. Good idea

@iamakulov
Copy link
Collaborator

Thinking about it again, and I think youʼre right, it makes sense for this repo!

Looking forward to merging this when we add transform-react-... examples :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we mention babel-react-optimize?
2 participants