You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Just giving this a spin with my own images and one of the reasons it doesn't currently work for me is that certain env variables (AIRFLOW__CORE__SQL_ALCHEMY_CONN and AIRFLOW__CORE__FERNET_KEY in particular) are composed in the entrypoint.sh as opposed to directly from env vars. It appears the airflow docker image is based on https://github.com/puckel/docker-airflow, is that correct? Are there reasons why the airflow Dockerfile wouldn't be part of this repo? (I'm using a different docker image which doesn't have the same entrypoint as that one.)
In any event, my suggestion would be to try and keep the go build process decoupled from any particular docker image/entrypoint. I see the args are configurable in utils.go. For sensitive config parameters (e.g. sql_alchemy_conn and fernet_key), these would probably have to come from kubernetes secrets and be injected as env_vars in the UI, scheduler, and k8s worker.
The text was updated successfully, but these errors were encountered:
Thanks for reaching out. Thats correct. I should have made it explicit in the readme or userguide (pending).
Please refer to my airflow-docker repo which is forked from puckel.
Just giving this a spin with my own images and one of the reasons it doesn't currently work for me is that certain env variables (
AIRFLOW__CORE__SQL_ALCHEMY_CONN
andAIRFLOW__CORE__FERNET_KEY
in particular) are composed in theentrypoint.sh
as opposed to directly from env vars. It appears the airflow docker image is based onhttps://github.com/puckel/docker-airflow
, is that correct? Are there reasons why the airflow Dockerfile wouldn't be part of this repo? (I'm using a different docker image which doesn't have the same entrypoint as that one.)In any event, my suggestion would be to try and keep the go build process decoupled from any particular docker image/entrypoint. I see the
args
are configurable inutils.go
. For sensitive config parameters (e.g.sql_alchemy_conn
andfernet_key
), these would probably have to come from kubernetes secrets and be injected asenv_vars
in the UI, scheduler, and k8s worker.The text was updated successfully, but these errors were encountered: