feat: add support for auto IAM authentication to Connector
#191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enocom
reviewed
Dec 29, 2023
|
Integration tests passing ✅ Just need to setup mock metadata server for unit tests |
enocom
reviewed
Jan 2, 2024
|
|
||
| # validate metadata exchange response | ||
| if resp.response_code != connectorspb.MetadataExchangeResponse.OK: | ||
| raise ValueError("Metadata Exchange request has failed!") |
There was a problem hiding this comment.
Let's add the error message from the response in here.
There was a problem hiding this comment.
let me know how this looks now, can't mimic the same as Go or Java as the Java and Go proto libraries at helper methods like GetResponseCode which I don't have here in PYthon
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jackwotherspoon
requested review from
cthumuluru,
nancynh and
a team
as code owners
jackwotherspoon
changed the title
jackwotherspoon
changed the title
Connector
enocom
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perform new metadata exchange for connection through the
Connectorclass and add support for automatic IAM authentication throughenable_iam_authnflag.Related to #152
NOTE: Still need to add support for auto iam authentication to
AsyncConnectorclass to add support for asyncpg, follow-up PR incoming.