Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: update distroless image #67

Merged
merged 4 commits into from Feb 24, 2022

Conversation

mathieu-benoit
Copy link
Contributor

Based on this doc from Jib:

However, even when you decide to keep using Distroless, at least we strongly recommend gcr.io/distroless/java-debian10:11, because, as of Apr 2021, gcr.io/distroless/java:{8,11} is based on Debian 9 that reached end-of-life. (Note gcr.io/distroless/java-debian10 doesn't have :8.)

And when looking at the distroless repo, there is even this new update/recommendation since 2021-12 hence this update with gcr.io/distroless/java11-debian11.

@mathieu-benoit mathieu-benoit requested a review from a team as a code owner January 21, 2022 21:41
@Shabirmean Shabirmean changed the title gcr.io/distroless/java11-debian11 cleanup: update distroless image Jan 21, 2022
@Shabirmean
Copy link
Member

@mathieu-benoit - were you able to run and test it with this image?

@mathieu-benoit mathieu-benoit marked this pull request as draft January 21, 2022 21:47
@mathieu-benoit
Copy link
Contributor Author

mathieu-benoit commented Jan 21, 2022

Sorry, meant to set this PR as Draft in order to continue my tests. Just did, and will report back here once tested.
Furthermore, there is this conventionalcommits.org asking me rename my commit, could we by-pass this or do you want me to proceed?

@Shabirmean
Copy link
Member

Sorry, meant to set this PR as Draft in order to continue my tests. Just did, and will report back here once tested. Furthermore, there is this conventionalcommits.org asking me rename my commit, could we by-pass this or do you want me to proceed?

I think for now it's okay since I know the changes. In future making the commits in the conventional commit format should fix it. Also the PR title should follow conventional commit style. I have changed the title for now

<small_tag>: <description>

examples:
fix: fixed somthing
cleanup: clear gitignore
doc: updated the readme
release: releasing new version

@mathieu-benoit
Copy link
Contributor Author

mathieu-benoit commented Jan 21, 2022

Oh ok gotcha, thanks. Out of curiosity, any automatic check/control for the PR's title convention? Or developer guide entry (sorry if I missed it)? Which could help any future contributors and avoid this error?

@Shabirmean
Copy link
Member

Oh ok gotcha, thanks. Out of curiosity, any automatic check/control for the PR's title convention? Or developer guide entry (sorry if I missed it)? Which could help any future contributors and avoid this error?

I think in general the conventional commits guide shall be useful

@mathieu-benoit
Copy link
Contributor Author

FYI: I was able to test it with inventory and payments, working succesfully. But I'm not able to build a new image for api-server because of this issue #70.

@mathieu-benoit mathieu-benoit marked this pull request as ready for review February 7, 2022 23:29
@mathieu-benoit
Copy link
Contributor Author

mathieu-benoit commented Feb 7, 2022

Hey @Shabirmean, leave it to you to decide but I think it's safe to merge this PR as I was able to test it with inventory and payments, we may want to assume that it's working with api-server, sorry not able to confirm with the latter because of #70.

@Shabirmean Shabirmean merged commit bd44b14 into GoogleCloudPlatform:main Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants