New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup: update distroless image #67
Conversation
gcr.io/distroless/java11-debian11
@mathieu-benoit - were you able to run and test it with this image? |
Sorry, meant to set this PR as Draft in order to continue my tests. Just did, and will report back here once tested. |
I think for now it's okay since I know the changes. In future making the commits in the conventional commit format should fix it. Also the PR title should follow conventional commit style. I have changed the title for now <small_tag>: <description>
examples:
fix: fixed somthing
cleanup: clear gitignore
doc: updated the readme
release: releasing new version |
Oh ok gotcha, thanks. Out of curiosity, any automatic check/control for the PR's title convention? Or developer guide entry (sorry if I missed it)? Which could help any future contributors and avoid this error? |
I think in general the conventional commits guide shall be useful |
FYI: I was able to test it with |
Hey @Shabirmean, leave it to you to decide but I think it's safe to merge this PR as I was able to test it with |
Based on this doc from
Jib
:And when looking at the
distroless
repo, there is even this new update/recommendation since 2021-12 hence this update withgcr.io/distroless/java11-debian11
.