Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow GitOps integration #169

Closed
therealmitchconnors opened this issue Sep 24, 2020 · 2 comments · Fixed by #171
Closed

Allow GitOps integration #169

therealmitchconnors opened this issue Sep 24, 2020 · 2 comments · Fixed by #171
Assignees
Labels
asm-installer Issues related to the asm-installer script

Comments

@therealmitchconnors
Copy link
Contributor

Currently, the script generates and installs ASM config, which is not suitable for GitOps integration. Ideally, users should treat their config as code, and review a diff of all changes before deploying to production via GitOps. I think all that is needed here is a way to dump the config to stdout instead of applying it directly.

@zerobfd
Copy link
Contributor

zerobfd commented Sep 30, 2020

I was thinking about this and realized this might not have been what you wanted. The PR prints the config from this repo as-is, i.e. without passing it through istioctl manifest generate. Is that your intent and/or do you know whether people would prefer dry or hydrated configs at this step in the pipeline?

@zerobfd zerobfd reopened this Sep 30, 2020
@zerobfd
Copy link
Contributor

zerobfd commented Oct 2, 2020

Chatted offline, going with dry for now and if someone expresses interest we can figure out how to support both.

@zerobfd zerobfd closed this as completed Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
asm-installer Issues related to the asm-installer script
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants