Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of deprecated Files API #18

Closed
someone1 opened this issue Feb 24, 2015 · 5 comments
Closed

Remove usage of deprecated Files API #18

someone1 opened this issue Feb 24, 2015 · 5 comments

Comments

@someone1
Copy link
Contributor

The API was deprecated in May 2013: https://cloud.google.com/appengine/docs/python/googlestorage/

The Pipeline API should be updated to use the cloudstorage library and the default GCS bucket (or configurable by user)

@burnhamup
Copy link

I've heard a rumor from Google that the Files API will be removed on May 1, 2015. This could render this library inoperable if this isn't fixed.

@tkaitchuck
Copy link
Contributor

The only use is here:
https://github.com/GoogleCloudPlatform/appengine-pipelines/blob/master/python/src/pipeline/pipeline.py#L1222

This one function should be very easy to re-write. To use https://github.com/GoogleCloudPlatform/appengine-gcs-client

I am keeping this open so it is not forgotten.

@svpino
Copy link
Contributor

svpino commented Apr 15, 2015

I'll take a stab at this one. The only issue is that tests are not running right now. I already submitted a PullRequest #28 to fix them. I'll work on this locally and submit another PullRequest when ready.

@mattjo
Copy link
Contributor

mattjo commented Jun 2, 2015

Here's a shot at removing the dependency. #37

@mattjo
Copy link
Contributor

mattjo commented Jun 5, 2015

#37 was merged yesterday, so I think this issue is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants