Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Use mvn instead of mvnw #924

Merged
merged 1 commit into from
Apr 28, 2023
Merged

chore: Use mvn instead of mvnw #924

merged 1 commit into from
Apr 28, 2023

Conversation

lqiu96
Copy link
Contributor

@lqiu96 lqiu96 commented Apr 28, 2023

No description provided.

@lqiu96 lqiu96 requested a review from emmileaf April 28, 2023 18:07
@lqiu96 lqiu96 mentioned this pull request Apr 28, 2023
Merged
emmileaf
emmileaf approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@emmileaf emmileaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - dropping a backlink to #923 for context

@lqiu96 lqiu96 force-pushed the master-update_mvn_folder_2 branch from ed8557e to df58eb9 Compare April 28, 2023 18:57
meltsufin
meltsufin approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@meltsufin meltsufin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the wrapper then. Same for spring-cloud-gcp. CC: @emmileaf.

@lqiu96
Copy link
Contributor Author

lqiu96 commented Apr 28, 2023

I'll remove the maven wrapper in a separate PR. Going to try and see if this fixes the release.

@lqiu96 lqiu96 merged commit 2d173bc into master Apr 28, 2023
@lqiu96 lqiu96 deleted the master-update_mvn_folder_2 branch April 28, 2023 20:35
@lqiu96
Copy link
Contributor Author

lqiu96 commented Apr 28, 2023 •
edited
Loading

FYI, there is an issue prevent the release: #925. I'll need to investigate some more.

JoeWang1127 pushed a commit that referenced this pull request Nov 29, 2023
@lqiu96
chore: Use mvn command (#924)
ba9f66f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmileaf emmileaf emmileaf approved these changes

@meltsufin meltsufin meltsufin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lqiu96 @emmileaf @meltsufin