deps: update to Guava 29.0-jre #837
Conversation
Codecov Report
@@ Coverage Diff @@
## master #837 +/- ##
=========================================
Coverage 78.45% 78.46%
Complexity 610 610
=========================================
Files 96 96
Lines 2409 2410 +1
Branches 282 282
=========================================
+ Hits 1890 1891 +1
Misses 411 411
Partials 108 108
Continue to review full report at Codecov.
|
| } | ||
| result.setFuture(executorService.submit(() -> consumeBytes(inputStream))); | ||
| ListenableFuture<String> submit = executorService.submit(() -> consumeBytes(inputStream)); |
There was a problem hiding this comment.
Any reason to expand this out?
There was a problem hiding this comment.
No semantic difference, but it makes refactoring, debugging, and updating easier. The more operations get crammed into a single statement the harder it becomes to read. In this case, it was difficult to demock without introducing local variables.
|
I think you need to rebase to pull in #838 to fix the cloud sdk on windows downgrade issue |
* update to Guava 28.2-jre * trivial change--http-->https-->to force CI to run again
@loosebazooka 28.2 marked several classes "Do Not Mock" which necessitated a surprisingly large number of changes.