Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: setup release please #970

Merged
merged 3 commits into from
Dec 13, 2023
Merged

fix: setup release please #970

merged 3 commits into from
Dec 13, 2023

Conversation

JoeWang1127
Copy link
Contributor

No description provided.

@JoeWang1127 JoeWang1127 marked this pull request as ready for review December 13, 2023 00:29
@suztomo
Copy link
Contributor

suztomo commented Dec 13, 2023 •
edited

You need the version.txt and https://github.com/GoogleCloudPlatform/spring-cloud-gcp/blob/main/.github/release-trigger.yml, at least. What else?

Search for any file whose name has "release" in spring-cloud-gcp.

Search for any file that has "release-please" in spring-cloud-gcp.

Find pull requests that added/modified these files.

@JoeWang1127
Copy link
Contributor Author

Search for any file whose name has "release" in spring-cloud-gcp.

Search for any file that has "release-please" in spring-cloud-gcp.

Only two files have "release" in name: release-please.yml and release-trigger.yml.

@suztomo
Copy link
Contributor

suztomo commented Dec 13, 2023

Release Please and Release Trigger are installed in this repository. Good.

Screenshot 2023-12-12 at 8 03 58 PM

@suztomo
Copy link
Contributor

suztomo commented Dec 13, 2023

When merging this pull request, update the title (+commit message) with "fix:" prefix so that Release Please should create a pull request.

@JoeWang1127 JoeWang1127 changed the title chore: setup release please fix: setup release please Dec 13, 2023
@JoeWang1127
Copy link
Contributor Author

When merging this pull request, update the title (+commit message) with "fix:" prefix so that Release Please should create a pull request.

Done.

suztomo
suztomo approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@suztomo suztomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this.

@JoeWang1127 JoeWang1127 merged commit b10b3c9 into main Dec 13, 2023
8 checks passed
@JoeWang1127 JoeWang1127 deleted the chore/setup-release-please branch December 13, 2023 03:06
@release-please release-please bot mentioned this pull request Dec 13, 2023
Closed
@release-please release-please bot mentioned this pull request Jan 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suztomo suztomo suztomo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JoeWang1127 @suztomo