Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump kpt version in hydration pipeline #126

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

shayfisher
Copy link
Contributor

Update kpt to version kpt:v1.0.0-beta.9.
Using the current version with the landing-zone blueprint fails with the following error for the workspace package:

Package "workspace":
error: resources must be annotated with config.kubernetes.io/index to be written to files

Upgrading to this version solved the issue.

Update kpt to version kpt:v1.0.0-beta.9.
Using the current version with the landing-zone blueprint fails with the following error for the workspace package:

Package "workspace": 
error: resources must be annotated with config.kubernetes.io/index to be written to files
@shayfisher shayfisher requested review from askmeegs and a team as code owners January 2, 2022 06:40
@google-oss-prow
Copy link

Hi @shayfisher. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shayfisher
Copy link
Contributor Author

@askmeegs Could you rescan the repo ? I've signed the CLA.
Thank you!

@bharathkkb bharathkkb changed the title Update hydration-trigger.yaml fix: bump kpt version in hydration pipeline Jan 5, 2022
@google-oss-prow google-oss-prow bot added the lgtm label Jan 5, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bharathkkb, shayfisher

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bharathkkb bharathkkb merged commit ef8afb3 into GoogleCloudPlatform:main Jan 5, 2022
@release-please release-please bot mentioned this pull request Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants