Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigTable should repackage io.grpc ? #582

Closed
christian-lefty opened this issue Nov 25, 2015 · 3 comments · Fixed by #584
Closed

BigTable should repackage io.grpc ? #582

christian-lefty opened this issue Nov 25, 2015 · 3 comments · Fixed by #584
Assignees
Labels
api: bigtable Issues related to the googleapis/java-bigtable-hbase API.

Comments

@christian-lefty
Copy link

It appears that the hbase bigtable jar is shipping a version of the io.grpc.protobuf.ProtoUtils
that's been shaded to operate on com.google.bigtable.repackaged.com.google.protobuf.*
messages.

This makes it impossible to build applications that are using both BigTable and GRPC (since our own classes need a version of ProtoUtils that works om com.google.protobuf.Messages)

My impression is that BigTable's ProtoUtils should be repackaged too to a private package?

sduskis added a commit to sduskis/cloud-bigtable-client that referenced this issue Nov 26, 2015
sduskis added a commit to sduskis/cloud-bigtable-client that referenced this issue Nov 26, 2015
@christian-lefty
Copy link
Author

By the way there seems to have other issues too.

google.com.oauth.* should be repackaged or it conflicts with projects using protobufs.

@kevinsi4508
Copy link
Contributor

Thanks Chris! We will work on the fix.
On Nov 27, 2015 4:26 AM, "christian rivasseau" notifications@github.com
wrote:

By the way there seems to have other issues too.

google.com.oauth.* should be repackaged or it conflicts with projects
using protobufs.


Reply to this email directly or view it on GitHub
#582 (comment)
.

sduskis added a commit to sduskis/cloud-bigtable-client that referenced this issue Nov 30, 2015
@sduskis
Copy link
Contributor

sduskis commented Nov 30, 2015

I updated the pom.xmls, and this may work for you. That said, if you're comfortable working with protobufs, and are willing to modify some code (hopefully slightly) in the near future, you can use the bigtable-client-core artifacts which don't need the hbase induced shading.

HBase uses old versions of protubuf, guava and some other libraries, and grpc uses newer versions. We shaded the grpc dependencies into our bigtable-hbase-1.* jars to get around that problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable-hbase API.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants