Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add support for deployment_type in apigee module #1114

Closed
blackillzone opened this issue Jan 27, 2023 · 2 comments
Closed

Comments

@blackillzone
Copy link
Contributor

Hello,

Since the provider support the deployment_type argument for Apigee environment deployments (hashicorp/terraform-provider-google#11405), it would be a nice upcoming add for the apigee module.

In the same time, we could also add the api_proxy_type parameter.

I guess it would be something like this for the module variables:

environments = {
    apis-test = {
      display_name = "APIs test"
      description  = "APIs Test"
      deployment_type = "PROXY"
      api_proxy_type = "PROGRAMMABLE"
      envgroups    = ["test"]
    }
}

And I suppose it should be optional, with default values at null, and if null, we don't set the options in the google_apigee_environment resource.

This way, the current module should be without breaking changes.

@blackillzone
Copy link
Contributor Author

Added #1115, and waiting for the CLA to be validated.

@juliocc
Copy link
Collaborator

juliocc commented Feb 7, 2023

Fixed with #1115

@juliocc juliocc closed this as completed Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants