Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing requirements in data-platform-foundations README #1521

Closed
danieldeleo opened this issue Jul 24, 2023 · 4 comments · Fixed by #1573
Closed

Missing requirements in data-platform-foundations README #1521

danieldeleo opened this issue Jul 24, 2023 · 4 comments · Fixed by #1573
Assignees

Comments

@danieldeleo
Copy link
Collaborator

danieldeleo commented Jul 24, 2023

https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/tree/master/blueprints/data-solutions/data-platform-foundations is missing a step instructing users to enable the following APIs before running Terraform:

  • Cloud Billing API
  • Cloud Resource Manager API
  • Cloud Pub/Sub API
  • Identity and Access Management (IAM) API
@danieldeleo danieldeleo changed the title Missing requirement in data-platform-foundations README Missing requirements in data-platform-foundations README Jul 24, 2023
@danieldeleo
Copy link
Collaborator Author

It's also missing a step to create the following 3 groups within the organization:

  • gcp-data-analysts
  • gcp-data-engineers
  • gcp-data-security

@lcaggio
Copy link
Collaborator

lcaggio commented Jul 24, 2023

Hi Daniel, thanks for flagging missing details in the README, could you send a PR to improve it? Thanks in advance for your help!

@ludoo
Copy link
Collaborator

ludoo commented Aug 5, 2023

@wiktorn want to take a stab at this since Lorenzo is OOO?

@wiktorn
Copy link
Collaborator

wiktorn commented Aug 6, 2023

Added fix for missing groups in #1573.

Not describing anything about enabling API's in default project as discussed in #1525 (i.e. it's part of setting up the service account for terraform that is generic, not specific to this specific blueprint).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment