Skip to content
This repository has been archived by the owner on May 15, 2019. It is now read-only.

Warning message for versions is a little confusing #64

Closed
jasonpolites opened this issue Mar 6, 2017 · 6 comments
Closed

Warning message for versions is a little confusing #64

jasonpolites opened this issue Mar 6, 2017 · 6 comments
Labels

Comments

@jasonpolites
Copy link
Contributor

I recently updated the emulator, and when I tried to execute a command I got this message:

The version of the currently running Emulator is lower than that of the installed CLI (1.0.0-alpha.11). Please shutdown any running Emulator processes and restart using the installed CLI.

OK.. that's cool, but it's not super-clear what it's telling me to do. Please shutdown any running Emulator processes.. am I supposed to manually kill the process? Recommend re-phrasing to:

"The version of the currently running Emulator is lower than that of the installed CLI (1.0.0-alpha.11). Please manually terminate any running Emulator processes, then restart using the CLI."

Also there's an extra space between "Emulator" and "is" in the current message.

Longer term we should look at how we can do this for the user, perhaps with a Y/N warning/question (assuming we can deduce the process ID from the file system etc)

@jasonpolites
Copy link
Contributor Author

Actually... this feels like a bug. I can't start the emulator at all now. I've confirmed I have no running processes, but I still just get the warning.

@jasonpolites
Copy link
Contributor Author

Maybe manually killing the process left the PID file on the file system?

@jmdobry
Copy link
Contributor

jmdobry commented Mar 6, 2017

You don't have any node processes at all? Also, try deleting ~/.config/configstore/@google-cloud/functions-emulator/

Maybe manually killing the process left the PID file on the file system?

Possibly, when you use the CLI to stop the Emulator, the PID is removed. I should update the Emulator to remove its own PID from the filesystem when the process exits.

jmdobry added a commit that referenced this issue Mar 6, 2017
@jmdobry jmdobry closed this as completed in 4da522b Mar 6, 2017
@jasonpolites
Copy link
Contributor Author

The fix in that commit 4da522b is likely to not work as the user can't invoke the functions CLI without the warning, and hence can't call functions kill

@jasonpolites jasonpolites reopened this Mar 6, 2017
@jmdobry
Copy link
Contributor

jmdobry commented Mar 6, 2017

I removed the line that prevented the user from calling functions kill

@jmdobry
Copy link
Contributor

jmdobry commented Apr 10, 2017

Done

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants