New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linkage Enforcer rule breaks on missing TypeToken class #1092
Comments
Thank you for reporting this and instruction on how to reproduce this. I confirmed I can reproduce the error. I will get back to this this week (hopefully tomorrow). |
DiagnosisLinkage Checker has a (wrong) assumption that the outer class of an inner class always exists in a class path. In this case, The class file is marked as an inner class of
|
Is the problem that they shaded the inner class without shading the outer class? I'm surprised that's even possible. |
The problem is not solely about curator-client..
|
Guava 11?! Their hadoop dependency is really old too. Some upgrades are needed here. |
Thanks I just checked and it works like a charm (with the SNAPSHOT). I was wondering if we could somehow integrate this tool with Maven's own shade plugin to make it aware of these issues while shading, because otherwise is going to be and endless battle. |
That's an interesting idea. I'll file a Maven issue to look into it. There is one case I know of where shaded classes are full of linkage errors and the developers insist they won't be called and don't matter. They might be right but it's worth thinking about. |
@iemejia Thank you for confirmation. We released a new version that includes this fix:
|
@elharo Yes that's a good argument but a bit risky, maybe to make the argument more solid they should shade only the classes that are used by the project + its linked classes (I don't know if this is possible but sounds at least most robust, but error-prone in the case of reflection). In the meantime most projects that don't use this linkage checking tool must live on faith until something breaks. |
And btw I don't think I have seen a single project that shades jetty correctly until now. Have you? Because I am interested on fixing that in other places. |
While trying to execute linkage-enforcer plugin on HBase I found this message
Full log:
You can reproduce it by running
mvn clean verify -DskipTests
on this repo https://github.com/iemejia/hbaseThe text was updated successfully, but these errors were encountered: