Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust alignment for 32-bit arch #197

Merged
merged 2 commits into from
May 18, 2022
Merged

Conversation

shubha-rajan
Copy link
Contributor

@shubha-rajan shubha-rajan commented May 17, 2022

Change Description

This fixes the panic: unaligned 64-bit atomic operation error on 386 architectures. Analogous change to GoogleCloudPlatform/alloydb-go-connector#33

Checklist

  • Make sure to open an issue as a
    bug/issue
    before writing your code! That way we can discuss the change, evaluate
    designs, and agree on the general idea.
  • Ensure the tests and linter pass
  • Appropriate documentation is updated (if necessary)

@shubha-rajan shubha-rajan requested a review from a team May 17, 2022 16:54
@shubha-rajan shubha-rajan changed the title fix: move OpenConns to front of instance struct to guarantee 64bit alignment fix: adjust alignment for 32-bit arch May 17, 2022
@shubha-rajan shubha-rajan merged commit 86e96ad into main May 18, 2022
@shubha-rajan shubha-rajan deleted the fix-panic-unaligned branch May 18, 2022 00:31
This was referenced May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants