feat: add pgx v5 support (#639) #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enocom
reviewed
Oct 9, 2023
e2e_postgres_test.go
Outdated
| @@ -162,6 +163,48 @@ func TestPostgresHook(t *testing.T) { | |||
| } | |||
| t.Log(now) | |||
| } | |||
| pgxv5.RegisterDriver("cloudsql-postgres") | |||
There was a problem hiding this comment.
Could we turn this into a table test?
postgres/pgxv5/postgres_test.go
Outdated
| ) | ||
|
|
||
| // Example shows how to use cloudsqlpostgres dialer | ||
| func ExamplePostgresConnection() { |
There was a problem hiding this comment.
We can omit this change -- it was a mistake to add it for pgxv4.
There was a problem hiding this comment.
Removed it for both v4 and v5.
enocom
changed the title
|
The update of the commit takes a long time to be propagated to the PR page. Will close it and reopen. |
enocom
approved these changes
Oct 12, 2023
e2e_postgres_test.go
Outdated
| IAMAuthN bool | ||
| }{ | ||
| { | ||
| "cloudsql-postgres", |
There was a problem hiding this comment.
We should use named properties here:
{
driver: "cloudsql-postgres",
source: ... // etc
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.