Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSC-based connections should use the DNS name in TLS config #728

Open
enocom opened this issue Feb 14, 2024 · 0 comments
Open

PSC-based connections should use the DNS name in TLS config #728

enocom opened this issue Feb 14, 2024 · 0 comments
Assignees
@jackwotherspoon
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@enocom
Copy link
Member

enocom commented Feb 14, 2024

Feature Description

When connecting to a PSC endpoint, we should use the PSC DNS name as the server name in the TLS configuration here:

cloud-sql-go-connector/internal/cloudsql/refresh.go

Line 234 in aeb4de1

ServerName: inst.String(),
.

That should also allow us to remove InsecureSkipVerify for PSC-based connections.

Sample code

No response

Alternatives Considered

No response

Additional Details

No response
@enocom enocom added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Feb 14, 2024
@enocom enocom self-assigned this Feb 14, 2024
@enocom enocom added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Feb 14, 2024
@enocom enocom assigned jackwotherspoon and unassigned enocom May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jackwotherspoon jackwotherspoon

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@enocom @jackwotherspoon