fix: retry 50x errors with exponential backoff #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds retry behavior to the two SQL Admin API calls. Any response that results in a 50x error will now be retried up to 5 times with exponential backoff and jitter between each attempt. The formula used to calculate the duration to wait is: 200ms * 1.618^(attempt + jitter) This calculation matches what the Cloud SQL Proxy v1 does and will not trigger any significant change in load on the backend.
|
For reference, the v1 code is here: https://github.com/GoogleCloudPlatform/cloud-sql-proxy/blob/88c0183c00e4c532243b8a7b4263b6770adcbdda/proxy/certs/certs.go#L155-L194. |
This was referenced Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds retry behavior to the two SQL Admin API calls. Any response that results in a 50x error will now be retried up to 5 times with exponential backoff and jitter between each attempt.
The formula used to calculate the duration to wait is:
200ms * 1.618^(attempt + jitter)
This calculation matches what the Cloud SQL Proxy v1 does and will not trigger any significant change in load on the backend.
Fixes #718