feat: expose context to debug logger #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @torkelrogstad! Will take a look shortly 😄 |
jackwotherspoon
approved these changes
May 14, 2024
There was a problem hiding this comment.
Overall, LGTM. I'll let @enocom also review as he implemented the original debug logging feature.
enocom
approved these changes
May 14, 2024
debug/debug.go
Outdated
| // Logger is the interface used for debug logging. By default, it is unused. | ||
| // | ||
| // Deprecated: use ContextLogger instead. |
There was a problem hiding this comment.
Let's say "Prefer ContextLogger" or similar. We'll keep letting people use Logger if they want.
enocom
added a commit
to GoogleCloudPlatform/alloydb-go-connector
that referenced
this pull request
May 14, 2024
Callers may now provide a context to correlate logs with trace IDs in their implementation of the interface. This is a port of GoogleCloudPlatform/cloud-sql-go-connector#797
Co-authored-by: Jack Wotherspoon <jackwoth@google.com>
enocom
added a commit
to GoogleCloudPlatform/alloydb-go-connector
that referenced
this pull request
May 14, 2024
Callers may now provide a context to correlate logs with trace IDs in their implementation of the interface. This is a port of GoogleCloudPlatform/cloud-sql-go-connector#797
enocom
reviewed
May 14, 2024
enocom
added a commit
to GoogleCloudPlatform/alloydb-go-connector
that referenced
this pull request
May 14, 2024
Callers may now provide a context to correlate logs with trace IDs in their implementation of the interface. This is a port of GoogleCloudPlatform/cloud-sql-go-connector#797
|
Thanks for the quick merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of my feature request from #796