Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retry failed google-auth-library requests #181

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

ruyadorno
Copy link
Contributor

Adds a custom gaxios config to be used in google-auth-library requests, setting a proper retry value. This should fix the flaky tests on CI and provide a more resilient solution to end users.

Fixes: #134
Fixes: #146

src/sqladmin-fetcher.ts Outdated Show resolved Hide resolved
src/sqladmin-fetcher.ts Show resolved Hide resolved
Copy link
Collaborator

@jackwotherspoon jackwotherspoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (once you commit your suggestion)

@ruyadorno ruyadorno force-pushed the add-google-auth-library-retry branch from 32a8cc0 to 8cf8fad Compare August 11, 2023 19:51
Adds a custom `gaxios` config to be used in `google-auth-library`
requests, setting a proper retry value. This should fix the flaky tests
on CI and provide a more resilient solution to end users.

Fix: #134
Fix: #146
@ruyadorno ruyadorno force-pushed the add-google-auth-library-retry branch from 8cf8fad to 3f6f886 Compare August 14, 2023 17:26
@ruyadorno ruyadorno merged commit 8988b45 into main Aug 14, 2023
29 checks passed
@ruyadorno ruyadorno deleted the add-google-auth-library-retry branch August 14, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TAP Tests: request to https: failed TAP Tests: Invalid response body while trying to fetch https: failed
2 participants