fix: silent refresh errors on active connection #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an instance already have active connections, it should not throw errors when trying to refresh cloud instance certificates in the background. Otherwise these errors will bubble up and stop the end user application. This changeset fixes it by adding a more resilient system to the CloudSQLInstance refresh logic that silents errors occured during refresh and keeps valid certificate data that can be used if a refresh is still ongoing or if any error happens when during a refresh. Fixes: #201
ruyadorno
force-pushed
the
fix-silent-refresh-errors-on-active-connection
branch
from
90fadef
to
c9ec581
Compare
jackwotherspoon
requested changes
Sep 25, 2023
|
@ruyadorno Let's try and keep naming consistent across languages where we can. This will help the long-term maintenance burden and allow future maintainers to ramp up on the code base a lot quicker. |
enocom
reviewed
Sep 25, 2023
enocom
reviewed
Sep 25, 2023
enocom
reviewed
Sep 26, 2023
enocom
reviewed
Sep 26, 2023
src/cloud-sql-instance.ts
Outdated
| // refresh errors to the final user, scheduling a new refresh instead. | ||
| if (this.stablishedConnection) { | ||
| if (currentRefreshId === this.scheduledRefreshID) { | ||
| this.scheduleRefresh(); |
There was a problem hiding this comment.
What happens to caller here? Do we block them until a new refresh is done? What happens if the refresh continues to fail? Do we block the event loop?
There was a problem hiding this comment.
No, we never block the event loop. What happens is that the current metadata value is still used for connections in that case.
ruyadorno
force-pushed
the
fix-silent-refresh-errors-on-active-connection
branch
from
095ecc4
to
0447d6e
Compare
ruyadorno
commented
Sep 26, 2023
Co-authored-by: Jack Wotherspoon <jackwoth@google.com>
jackwotherspoon
approved these changes
Sep 26, 2023
ruyadorno
deleted the
fix-silent-refresh-errors-on-active-connection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an instance already have active connections, it should not throw errors when trying to refresh cloud instance certificates in the background. Otherwise these errors will bubble up and stop the end user application.
This PR fixes it by adding a more resilient system to the CloudSQLInstance refresh logic that silents errors occured during refresh and keeps valid certificate data that can be used if a refresh is still ongoing or if any error happens when during a refresh.
Fixes: #201