Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: update IpAdressesTypes to IpAddressTypes #94

Merged
merged 2 commits into from
Apr 18, 2023
Merged

refactor!: update IpAdressesTypes to IpAddressTypes #94

merged 2 commits into from
Apr 18, 2023

Conversation

jackwotherspoon
Copy link
Collaborator

Changing IpAdressesTypes to IpAddressTypes, removing double pluralization and typo

@jackwotherspoon jackwotherspoon self-assigned this Apr 18, 2023
@jackwotherspoon jackwotherspoon requested a review from a team as a code owner April 18, 2023 20:10
@jackwotherspoon jackwotherspoon changed the title chore: update IpAdressesTypes to IpAddressTypes chore: update IpAdressesTypes to IpAddressTypes Apr 18, 2023
ruyadorno
ruyadorno suggested changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@ruyadorno ruyadorno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually a breaking change since IpAddressTypes is exported to final users, can you please just change the commit prefix to use refactor!: instead of chore:

@jackwotherspoon jackwotherspoon changed the title chore: update IpAdressesTypes to IpAddressTypes refactor!: update IpAdressesTypes to IpAddressTypes Apr 18, 2023
ruyadorno
ruyadorno approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@ruyadorno ruyadorno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @jackwotherspoon!

@jackwotherspoon jackwotherspoon merged commit e38d392 into main Apr 18, 2023
@jackwotherspoon jackwotherspoon deleted the IpAddressTypes branch April 18, 2023 20:37
@release-please release-please bot mentioned this pull request Apr 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruyadorno ruyadorno ruyadorno approved these changes

Assignees

@jackwotherspoon jackwotherspoon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jackwotherspoon @ruyadorno