feat: add support for Auto IP #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need to add this option to the FUSE path as well. Currently FUSE assumes public IP always. EDIT: I'll split this wiring out as a separate fix PR. |
This commit restores a legacy behavior of the v1 Proxy, this time behind the flag --auto-ip. When the flag is enabled, the Proxy will first attempt to use a public IP. If no public IP is present, the Proxy will second attempt to use a private IP. If neither is present, the Proxy errors as expected. This new flag is primarily to support legacy behavior and should not be used in production otherwise.
jackwotherspoon
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit restores a legacy behavior of the v1 Proxy, this time behind the flag --auto-ip. When the flag is enabled, the Proxy will first attempt to use a public IP. If no public IP is present, the Proxy will second attempt to use a private IP. If neither is present, the Proxy errors as expected.
This new flag is primarily to support legacy behavior and should not be used in production otherwise.
Fixes #1732.