Distributed tracing support in gRPC #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjin
requested review from
ofrobots,
matthewloring,
cristiancavalli and
DominicKramer
googlebot
added
the
cla: yes
| @@ -442,6 +470,12 @@ module.exports = [ | |||
| unpatch: unpatchClient | |||
| }, | |||
| { | |||
| file: 'src/node/src/metadata.js', | |||
| versions: SUPPORTED_VERSIONS, | |||
| patch: patchMetadata, | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@matthewloring Once tests pass could you take a look at 80888a6? It addresses the previously failing tests. |
|
CI failure is due to our MySQL tracing tests failing on Node v7.7.2. I can reproduce this locally with v7.7.2 but not v7.7.1, indicating that it arose as a result of the new version of Node being released. We should fix this in a separate PR. |
|
LGTM given failures unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #434. This changes the gRPC plugin to add the
'x-cloud-trace-context'metadata field to outgoing gRPC requests, and read it from incoming gRPC requests.