Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add url field to hapi middleware options #447

Merged
merged 1 commit into from Mar 22, 2017

Conversation

ethanrubio
Copy link
Contributor

Currently, the config ignoreUrls won't work when working with a Hapi server, since the url field does not exist when runInRootSpan is called.

See #446

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Mar 22, 2017
@ethanrubio
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Mar 22, 2017
@kjin
Copy link
Contributor

kjin commented Mar 22, 2017

Thanks for contributing this! Usually we would like a unit test to go a long with it, but since we have to fix this for other modules, we'll add a follow-up to add unit tests for each of the web framework modules.

This looks good to me, so I'll merge it as soon as the CIs pass.

@kjin
Copy link
Contributor

kjin commented Mar 22, 2017

v0.12 failures unrelated. Merging.

@kjin kjin merged commit c108b35 into googleapis:master Mar 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants