Stop running google-gax unit test on v0.12 #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjin
requested review from
ofrobots,
matthewloring,
cristiancavalli and
DominicKramer
googlebot
added
the
cla: yes
matthewloring
approved these changes
Mar 23, 2017
README.md
Outdated
| * [MongoDB-core](https://www.npmjs.com/package/mongodb-core) (version 1) | ||
| * [Mongoose](https://www.npmjs.com/package/mongoose) (version 4) | ||
| * [Redis](https://www.npmjs.com/package/redis) (versions 0.12 - 2) | ||
| * [MySQL](https://www.npmjs.com/package/mysql) (version ^2.9) | ||
|
|
||
| *Note: The latest versions of gRPC (versions 1.1 and up) have dropped support for Node.js <4.0. We do not officially support tracing gRPC on unsupported versions of Node.js. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
kjin
force-pushed
the
drop-google-gax-0.12
branch
from
08c0b5a
to
d889dcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
google-gaxplugin unit test doesn't work on Node v0.12 + gRPC v1.2, so this change stops it from running. I've also added a disclaimer in the README stating that in general, we won't officially provide support for modules that depend on gRPC (or gRPC itself) if the application is running on a version of Node that that version of gRPC does not support.