fix: wrong test/assertion in test-trace-http #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
CI failures seem like a flakiness. @kjin can you rerun Appveyor? |
The wrong test is 'should not trace api requests'. The header name to check should be TRACE_AGENT_REQUEST_HEADER, not TRACE_CONTEXT_HEADER_NAME. Also the assertion should be done against the number of spans, not against the number of traces. Also fix the order of arguments to `assert.equal()` calls. The first argument must be the actual result and the second the expected value.
|
@kjin All tests passed now. Can you take a look? |
kjin
approved these changes
Nov 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wrong test is 'should not trace api requests'. The header name to
check should be TRACE_AGENT_REQUEST_HEADER, not
TRACE_CONTEXT_HEADER_NAME. Also the assertion should be done against the
number of spans, not against the number of traces.
Also fix the order of arguments to
assert.equal()calls. The firstargument must be the actual result and the second the expected value.