Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting scope in permission check #21

Merged
merged 2 commits into from
Apr 17, 2016

Conversation

fogs
Copy link
Contributor

@fogs fogs commented Apr 17, 2016

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@fogs
Copy link
Contributor Author

fogs commented Apr 17, 2016

I signed it.

Google, you owe me the better part of a Saturday.

Regards,
fogs

2016-04-17 12:54 GMT+02:00 googlebot notifications@github.com:

Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project. Before we can look at your
pull request, you'll need to sign a Contributor License Agreement (CLA).

[image: 📝] Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll

verify. Thanks.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#21 (comment)

SPF Guru GmbH
Hermannstraße 9
20095 Hamburg
Deutschland

Amtsgericht Hamburg, HRB 140092
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Nils-Oliver Brahmstädt

@googlebot
Copy link

CLAs look good, thanks!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@googlebot
Copy link

CLAs look good, thanks!

@Carrotman42 Carrotman42 merged commit 0574a46 into GoogleCloudPlatform:master Apr 17, 2016
@Carrotman42
Copy link
Contributor

Thanks for this CL, sorry about the frustration it caused.

I'll compile and release a new version tomorrow.

@minodisk
Copy link
Contributor

Is b.gcr.io/cloudsql-docker/gce-proxy re-published ?

cloudsql-proxy container in k8s error still occurs:

the default Compute Engine service account is not configured with sufficient permissions to access the Cloud SQL API from this VM. Please create a new VM with Cloud SQL access (scope) enabled under "Identity and API access". Alternatively, create a new "service account key" and specify it using the -credentials_file parameter

But with my re-published container, error doesn't occur: https://hub.docker.com/r/syoya/cloudsql-proxy/~/dockerfile/

@Carrotman42
Copy link
Contributor

The --version command will show the commit at which the proxy was built. Make sure that you're pulling the latest version. When I do it locally:

~/ $ docker pull b.gcr.io/cloudsql-docker/gce-proxy
Using default tag: latest
latest: Pulling from cloudsql-docker/gce-proxy

Digest: sha256:e4aa8dd14bd56ea6a8537a2464dcea36bd74a52def850f4dde95e29a154829d5
Status: Image is up to date for b.gcr.io/cloudsql-docker/gce-proxy:latest
~/ $ docker run b.gcr.io/cloudsql-docker/gce-proxy /cloud_sql_proxy --version
Cloud SQL Proxy: version 1.04; sha 0574a46 built Mon Apr 18 18:44:32 UTC 2016

Which is the merged commit above (0574a46)

@minodisk
Copy link
Contributor

@Carrotman42 Thanks, I confirmed 🍣

@halkeye
Copy link

halkeye commented Apr 28, 2016

I'm trying to pull it using gce. I'm not sure if the recent code introduced the change, or I'm pulling an older version

kubectl rolling-update app-controller --image=b.gcr.io/cloudsql-docker/gce-proxy:latest --container=cloudsql-proxy

 $ kubectl logs app-controller-fa8f4fb48ef77e94df4e26e5b780de0c-e8pu1 --container=cloudsql-proxy
2016/04/28 23:52:45 the default Compute Engine service account is not configured with sufficient permissions to access the Cloud SQL API from this VM. Please create a new VM with Cloud SQL access (scope) enabled under "Identity and API access". Alternatively, create a new "service account key" and specify it using the -credentials_file parameter

@halkeye
Copy link

halkeye commented Apr 29, 2016

I built and pushed a new one using ./build.sh docker and things are working fine now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants