-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correcting scope in permission check #21
Conversation
There is no such service as https://www.googleapis.com/auth/sqladmin. The correct scope name is https://www.googleapis.com/auth/sqlservice.admin and there is even a constant for that.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it. Google, you owe me the better part of a Saturday. Regards, 2016-04-17 12:54 GMT+02:00 googlebot notifications@github.com:
SPF Guru GmbH Amtsgericht Hamburg, HRB 140092 |
CLAs look good, thanks! |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
CLAs look good, thanks! |
Thanks for this CL, sorry about the frustration it caused. I'll compile and release a new version tomorrow. |
Is
But with my re-published container, error doesn't occur: https://hub.docker.com/r/syoya/cloudsql-proxy/~/dockerfile/ |
The --version command will show the commit at which the proxy was built. Make sure that you're pulling the latest version. When I do it locally: ~/ $ docker pull b.gcr.io/cloudsql-docker/gce-proxy Digest: sha256:e4aa8dd14bd56ea6a8537a2464dcea36bd74a52def850f4dde95e29a154829d5 Which is the merged commit above (0574a46) |
@Carrotman42 Thanks, I confirmed 🍣 |
I'm trying to pull it using gce. I'm not sure if the recent code introduced the change, or I'm pulling an older version
|
I built and pushed a new one using |
Replacing https://www.googleapis.com/auth/sqladmin with https://www.googleapis.com/auth/sqlservice.admin
Fixing #20