Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix credential flow. #266

Merged
merged 1 commit into from
Mar 29, 2019
Merged

Fix credential flow. #266

merged 1 commit into from
Mar 29, 2019

Conversation

kurtisvg
Copy link
Contributor

Fixes #263.

@kurtisvg kurtisvg requested a review from hfwang March 20, 2019 22:07
@kurtisvg kurtisvg added Status: Review Needed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Mar 20, 2019
@kurtisvg
Copy link
Contributor Author

@hfwang PTAL - this needs to be in before next release

@hfwang hfwang merged commit e027062 into master Mar 29, 2019
@kurtisvg kurtisvg deleted the cred-fix branch October 10, 2019 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfwang hfwang Awaiting requested review from hfwang

Assignees
No one assigned
Labels
type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kurtisvg @hfwang