Set custom per instance socket address #289
Conversation
Example: -instances=my-project:us-central1:sql-inst=unix:custom_socket_name Resolves: #241
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
kurtisvg
added
the
type: feature request
|
Thanks for stepping in. Ofc I'm fine with that. 👍 |
kurtisvg
added
cla: yes
priority: p2
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
PR #289 broke this support by using net.JoinHostPort, which wraps a v6 address in square brackets, e.g. [::1] This resulted in a double-wrapping - the resultant address was something like "[[::1]]:3306". Also add tests explicitly for listening on the "tcp4" and "tcp6" nets.
PR #289 broke this support by using net.JoinHostPort, which wraps a v6 address in square brackets, e.g. [::1] This resulted in a double-wrapping - the resultant address was something like "[[::1]]:3306". Also add tests explicitly for listening on the "tcp4" and "tcp6" nets.
PR #289 broke this support by using net.JoinHostPort, which wraps a v6 address in square brackets, e.g. [::1] This resulted in a double-wrapping - the resultant address was something like "[[::1]]:3306". Also add tests explicitly for listening on the "tcp4" and "tcp6" nets.
Fork of #265, updated to include automatic addition of the suffix for Postgres instances.