Skip to content
This repository has been archived by the owner on Feb 3, 2023. It is now read-only.

[FEATURE] Format column names #54

Open
ricardolsmendes opened this issue Aug 11, 2021 · 4 comments
Open

[FEATURE] Format column names #54

ricardolsmendes opened this issue Aug 11, 2021 · 4 comments

Comments

@ricardolsmendes
Copy link
Contributor

What would you like to be added:
Support for column name formatting.

Why is this needed:
The Sisense BI Connector uses Entry Schemas to represent some asset fields. Data Catalog requires the ColumnSchema's column field to fit a specific bytes-size limit and character encoding, which is currently not supported by the connectors commons library but should be.

Below changes narrow down the scope of the present feature request:

  1. Merge google.datacatalog_connectors.sisense.prepare.sisense_connector_strings_helper.py with google.datacatalog_connectors.commons.prepare.datacatalog_strings_helper.py.
  2. Delete ...sisense.prepare.sisense_connector_strings_helper.py.
  3. Refactor ...commons.prepare.DataCatalogStringsHelper to turn normalize_string into a public method.
  4. Refactor ...commons.prepare.BaseEntryFactory to call ...commons.prepare.DataCatalogStringsHelper.normalize_string instead of declaring its own __normalize_string method as it will become a duplicate.
  5. Refactor ...sisense.prepare.datacatalog_entry_factory.DataCatalogEntryFactory to call ...commons.prepare.DataCatalogStringsHelper.normalize_string as the
    current dependency will no longer exist after the refactoring.
  6. Refactor ...sisense.prepare.datacatalog_tag_factory.DataCatalogTagFactory to call ...commons.prepare.DataCatalogStringsHelper.normalize_string as the current dependency will no longer exist after the refactoring.
@github-actions
Copy link

This issue has been automatically marked as stale because it hasn't had any activity in 60 days. It will be closed in 7 days if no further activity occurs (e.g. changing labels, comments, commits, etc.). Please feel free to tag a maintainer and ask them to remove the label if you think it doesn't apply. Thank you for submitting this issue and helping to make Google Data Catalog Connectors better!

@github-actions
Copy link

This issue has been automatically marked as stale because it hasn't had any activity in 60 days. It will be closed in 7 days if no further activity occurs (e.g. changing labels, comments, commits, etc.). Please feel free to tag a maintainer and ask them to remove the label if you think it doesn't apply. Thank you for submitting this issue and helping to make Google Data Catalog Connectors better!

@github-actions
Copy link

This issue has been automatically marked as stale because it hasn't had any activity in 60 days. It will be closed in 7 days if no further activity occurs (e.g. changing labels, comments, commits, etc.). Please feel free to tag a maintainer and ask them to remove the label if you think it doesn't apply. Thank you for submitting this issue and helping to make Google Data Catalog Connectors better!

@github-actions
Copy link

This issue has been automatically marked as stale because it hasn't had any activity in 60 days. It will be closed in 7 days if no further activity occurs (e.g. changing labels, comments, commits, etc.). Please feel free to tag a maintainer and ask them to remove the label if you think it doesn't apply. Thank you for submitting this issue and helping to make Google Data Catalog Connectors better!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants