Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor variables.tf and reduce use of local-exec #106

Closed

Conversation

zefdelgadillo
Copy link

@zefdelgadillo zefdelgadillo commented Oct 17, 2023

This PR begins to address #104 by:

  • Removing defaults in variables.tf where user input is required
  • Use a terraform.default.tfvars to guide users on required variables
  • Removes local-exec in Cloud DNS configuration, replacing with a direct Terraform resource

This also fixes #105 by using direct role references rather than interpolated strings, fixing a bug where Terraform would try to apply a permission before the custom role was created.

Note: The build is still failing on a few issues, but this should be a good baseline update that will help make it easier to isolate those with future PRs.

@zefdelgadillo zefdelgadillo closed this by deleting the head repository May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use direct references rather than interpolated strings for custom roles
2 participants