Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use firestore db name different from (default) #119

Closed

Conversation

francescpuig7
Copy link

@francescpuig7 francescpuig7 commented Dec 21, 2023

This PR fixes #118

By default, tag engine works with the native firestore database called (default), proposed changes:

  • Support firestore client with database parameter in JobManager, TaskManager, TagEngineStoreHandler...
  • Support create indexes to firestore from new positional param with database name
  • Fix get_task_count
  • Add docu to README.md

resolve #118
close #118

Copy link

google-cla bot commented Dec 21, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@francescpuig7
Copy link
Author

@shirleycohen Can you check that everything is ok? I have signed the CLA

@shirleycohen
Copy link
Collaborator

Thank you @francescpuig7. I've added this functionality to v2.2.9. I apologize for the long delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use db firestore with a name other than (default)
2 participants