Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enter PIN screen look different in iOS and Android #186

Closed
morethanreal opened this issue Apr 20, 2020 · 7 comments · Fixed by #345
Closed

Enter PIN screen look different in iOS and Android #186

morethanreal opened this issue Apr 20, 2020 · 7 comments · Fixed by #345
Assignees
Labels
Bug Indicates that this issue describes something that isn't working as expected iOS Issues related to iOS (or applicable to both mobile apps) P1 High priority issue (must be done soon)
Milestone

Comments

@morethanreal
Copy link

The Android screen to enter your PIN looks much nicer than the equivalent screen on iOS. Let's center align the icon and text elements on iOS so it looks the same.

@morethanreal morethanreal added Feature request Use this tag for issues that describe a request for new features or functionality. iOS Issues related to iOS (or applicable to both mobile apps) labels Apr 20, 2020
@jkrogers18 jkrogers18 added the P1 High priority issue (must be done soon) label Apr 23, 2020
@jkrogers18
Copy link
Collaborator

+1 to this issue. The pin screen in iOS looks non-standard and has strange sizing and centering.

@jkrogers18
Copy link
Collaborator

Additional issue with this screen: the text at the bottom of the screen (that allows the user to logout if they have forgotten their PIN) is too far down and is partially off the bottom of the screen

Screenshot attached.

80601

@morethanreal
Copy link
Author

It seems like the screen layout is a ResearchKit limitation. Why does the PIN code screen has to be implemented in ResearchKit?

@SR-btc
Copy link
Collaborator

SR-btc commented May 5, 2020

@tushar-boston please provide your input. Any RK limitations here?

@tushar-boston
Copy link
Contributor

@tushar-boston please provide your input. Any RK limitations here?

Yes, the whole UI is rendering from RK.

@SR-btc
Copy link
Collaborator

SR-btc commented May 5, 2020

Since the ResearchKit framework was being used for the rest of the iOS app, and because it provides the Passcode screen, it was used for this screen as well, unlike in Android where it was built as a custom screen. However, with newer OS versions, there have been some changes in the screen's appearance over time and across devices and screen sizes. While the team had done some optimization already, the screen still appears to be having issues in certain devices.

The iOS team has checked potential solutions and has identified some quick fixes that can be done for now (which includes tweaking a default RK value as well). This will solve some of the appearance issues for now (including the Cancel button appearing to be above the Forgot Passcode link), but the proper, long-term fix would be to upgrade to the latest RK version and/or apply customization, and that can be taken up as part of platform enhancement work subsequently.

The iOS team will raise a PR with the quick fix and we need another ticket to track that this change be reverted (the part that has a RK value tweaked) after this launch and replaced with a long-term fix subsequently for the repo. The long-term fix will not change the default RK values, and so developers who upgrade the app to newer versions of RK in the future, will not have issues related to this.

@SR-btc SR-btc removed their assignment May 5, 2020
@SR-btc SR-btc added Bug Indicates that this issue describes something that isn't working as expected and removed Feature request Use this tag for issues that describe a request for new features or functionality. labels May 5, 2020
@SR-btc
Copy link
Collaborator

SR-btc commented May 5, 2020

For ease of tracking, changed this issue to the bugs category to track the quick fix being done and the long-term solution has been raised as a new ticket and as an enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Indicates that this issue describes something that isn't working as expected iOS Issues related to iOS (or applicable to both mobile apps) P1 High priority issue (must be done soon)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants