Allow disabling X-Frame-Options headers by passing None.
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@theacodes Please let me know if I should remove the commit with the unittest2 assert method changes 😀 |
theacodes
approved these changes
Oct 5, 2018
|
LGTM, but can you resolve the conflicts? Thank you for doing all this! |
This helps improve the error output, e.g. by showing the collection that was checked by assertIn and assertNotIn.
|
@theacodes Done, and no problem! 👋 |
theacodes
approved these changes
Oct 5, 2018
|
Thank you 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
frame-ancestorsdirective in CSP 2 allows basically the same thing and setting theX-Frame-Optionsheader withallow-fromisn't supported by Chrome and Safari anyway, we might as well allow disabling it completely.