Fix handling policy directives with multiple sources. #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theacodes
approved these changes
Oct 5, 2018
|
@theacodes Could I trouble you with a PyPI release of the recent changes? Alternatively I'm happy to spend time on release maintenance as well. |
|
If you'll send a PR to update the version and such, I'll merge and publish.
😎
…On Mon, Oct 8, 2018, 12:43 AM Jannis Leidel ***@***.***> wrote:
@theacodes <https://github.com/theacodes> Could I trouble you with a PyPI
release of the recent changes? Alternatively I'm happy to spend time on
release maintenance as well.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#32 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAPUc4IK_hI9F0CV-_txwlp0AA4ozTarks5uiwIFgaJpZM4XKu3s>
.
|
|
@theacodes Thank you! 🤓 See #33 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is kind of a big deal as it prevents the extension to correctly generate policy directives when multiple sources are used. (for when the policy is provided as a string, e.g. from an env var)