This repository has been archived by the owner on Jun 5, 2023. It is now read-only.
New Cloud Asset API resources #2235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* compute.forwardingRule * compute.instanceGroup * compute.instanceGroupManager * compute.router
Codecov Report
@@ Coverage Diff @@
## dev #2235 +/- ##
==========================================
+ Coverage 88.85% 88.87% +0.01%
==========================================
Files 175 175
Lines 13348 13443 +95
==========================================
+ Hits 11860 11947 +87
- Misses 1488 1496 +8
|
blueandgold
approved these changes
Nov 12, 2018
| @@ -348,6 +350,24 @@ def iter_compute_firewalls(self, project_number): | |||
| for rule in resources: | |||
| yield _fixup_resource_keys(rule, cai_to_gcp_key_map) | |||
|
|
|||
| def iter_compute_forwardingrules(self, project_number): | |||
There was a problem hiding this comment.
after double check I realized this already exists, so deleted
| @@ -498,6 +550,25 @@ def iter_compute_networks(self, project_number): | |||
| for network in resources: | |||
| yield _fixup_resource_keys(network, cai_to_gcp_key_map) | |||
|
|
|||
| def iter_compute_routers(self, project_number): | |||
| @@ -932,6 +1003,43 @@ def fetch_iam_serviceaccount_iam_policy(self, name, unique_id): | |||
| # Service accounts with no IAM policy return an empty dict. | |||
| return {} | |||
|
|
|||
| def iter_iam_organization_roles(self, org_id): | |||
There was a problem hiding this comment.
| for role in resources: | ||
| yield role | ||
|
|
||
| def iter_iam_project_roles(self, project_id, project_number): |
There was a problem hiding this comment.
6 tasks
joecheuk
pushed a commit
that referenced
this pull request
Dec 5, 2018
* Fetch IAM custom roles using Cloud Asset data. * Fetch Pub/Sub Topics and IAM Policies from Cloud Asset data. * Fetch additional Compute Engine resources from Cloud Asset data. * compute.forwardingRule * compute.instanceGroup * compute.instanceGroupManager * compute.router * Fix flake8 errors.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for opening a Pull Request!
Here's a handy checklist to ensure your PR goes smoothly.
pylint --rcfile=pylintrcpasses.These guidelines and more can be found in our contributing guidelines.