Skip to content
This repository has been archived by the owner on Jun 5, 2023. It is now read-only.

Update IamClient to allow getting service account keys by type. #657

Merged
merged 1 commit into from Sep 18, 2017

Conversation

ahoying
Copy link
Collaborator

@ahoying ahoying commented Sep 18, 2017

Thanks for opening a Pull Request!

Here's a handy checklist to ensure your PR goes smoothly.

  • I signed Google's Contributor License Agreement
  • My code conforms to Google's python style.
  • My PR at a minimum doesn't decrease unit-test coverage (if applicable).
  • My PR has been functionally tested.
  • All of the unit-tests still pass.
  • Running pylint --rcfile=pylintrc passes.

These guidelines and more can be found in our contributing guidelines.

@codecov
Copy link

codecov bot commented Sep 18, 2017

Codecov Report

Merging #657 into dev will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##              dev     #657      +/-   ##
==========================================
+ Coverage   83.62%   83.64%   +0.01%     
==========================================
  Files         165      165              
  Lines        8313     8321       +8     
==========================================
+ Hits         6952     6960       +8     
  Misses       1361     1361
Impacted Files Coverage Δ
google/cloud/security/common/gcp_api/iam.py 100% <100%> (ø) ⬆️

Copy link
Contributor

@blueandgold blueandgold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ahoying ahoying merged commit 26e8f18 into dev Sep 18, 2017
@ahoying ahoying deleted the key_types branch September 18, 2017 20:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants